Skip to content
This repository has been archived by the owner on Feb 27, 2023. It is now read-only.

Minor improvements #60

Merged
merged 1 commit into from
Sep 17, 2021
Merged

Minor improvements #60

merged 1 commit into from
Sep 17, 2021

Conversation

liamsi
Copy link
Member

@liamsi liamsi commented Sep 16, 2021

  • remove obsolete key param in updateWithSideNodes introduced in Implement removal of orphan nodes #37 and only removed on deletes a207801
  • remove redundant parentheses
  • properly format example code and make explicit that Update returns two params

As a nice side effect this will trigger having a baseline on master for future benchmark runs of bencher.

- remove obsolete key param in updateWithSideNodes
- remove redundant parentheses
- properly format example code and make explicit that Update returns to params
@orijbot
Copy link

orijbot commented Sep 16, 2021

@liamsi liamsi requested review from tzdybal and musalbas September 16, 2021 16:23
@codecov-commenter
Copy link

Codecov Report

Merging #60 (ce2ab73) into master (5f13c0f) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #60   +/-   ##
=======================================
  Coverage   85.62%   85.62%           
=======================================
  Files           6        6           
  Lines         466      466           
=======================================
  Hits          399      399           
  Misses         39       39           
  Partials       28       28           
Impacted Files Coverage Δ
smt.go 80.78% <100.00%> (ø)
utils.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f13c0f...ce2ab73. Read the comment docs.

@liamsi liamsi requested a review from adlerjohn September 17, 2021 10:29
Copy link
Member

@tzdybal tzdybal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liamsi liamsi merged commit d95f5f4 into master Sep 17, 2021
@liamsi liamsi deleted the ismail/minor_fixes branch September 17, 2021 10:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants